rht

Results 789 comments of rht

Hmmm...these commits almost hit the mark, except that 1. You haven't replaced _all_ the occurrences of `str_address` and `py_address` with `Address` for internal consistency of the data types. 2. Several...

Travis failed to install the python packages, but this commit passes all the tests in ejtp/tests.

In the .git/config of your Mesa git repo, make sure to add ``` [pull] rebase = true ``` This will prevent the noisy merge commits when you pull from Mesa...

I diff-ed the model.py of this PR with the undirected version: ``` 18c18 < return sum(1 for a in model.grid.get_all_cell_contents() if a.state is state) --- > return sum([1 for a...

Here is a diff of server.py: ``` 8c8 < from .model import VirusOnNetwork, State, number_infected --- > from .model import VirusOnNetworkDirected, State, number_infected 37c37,39 < "tooltip": f"id: {agents[0].unique_id}state: {agents[0].state.name}", ---...

@AdamCordner641 I'm not sure how it happened, but you have accidentally included a commit in the main branch in this PR. Have you made sure to add https://github.com/projectmesa/mesa/pull/1223#issuecomment-1084010129 ? And...

I still think that the example in this PR doesn't showcase directed networks. It's behaviorally identical to the undirected version. To make it different, I think we need to implement...

I think we should defer this PR, and do a separate PR that implements `DirectedNetworkSpace` with tests. Once this is done, we can revisit this PR.

I concur with the need of compartmentalizing the authority of a PyPI access token. Although, speaking of security, one drawback with using the GH Actions is that it doesn't have...

Progress update: I have simplified the non-straightforward code in #469. My prototype simply needs to be cleaned up. ![2022-05-18-065916_1195x549_scrot](https://user-images.githubusercontent.com/395821/169042043-b4799061-5701-4056-b069-195e1145cdaa.png)