rht

Results 789 comments of rht

Yeah, so that the diff is minimal, and GitHub doesn't flag the merge conflict.

I ran the CI. It looks like el_farol.ipynb is not properly Blacked yet. Make sure to use the latest version of Black locally.

Are you on Python 3.9, or 3.11? The CI Black runs on 3.10.

I'm on Python 3.10, Black 22.1.0, and running Black did indeed reformat the .ipynb. It's mostly removing the trailing `"\n"`. Another thing I noticed is that the .ipyn is 1.09...

@danielxu05 I tried to clean up your PR, tried rebasing it on top of main, but the procedure is too complicated, due to lots of merge commits in this PR....

Ugh, this is actually a breaking change, because HexGridVisualization and CanvasGridVisualization assume `model.grid`. Should we introduce this breaking change?

There is always room for adding an informative error message, at the right time. In the 2 classes, we check if users have `model.grid` defined. If so, we raise an...

We sidestepped the `model.datacollector` naming by introducing `model.initialize_datacollector` (which does initial data collection under the hood, where people often forget to do). But we can't do the same with space/grid,...

The width and height could be passed explicitly, but what about https://github.com/projectmesa/mesa/blob/685494d4b022312ebeabf7dd89013b3bdd6526c2/mesa/visualization/modules/CanvasGridVisualization.py#L97 ?

This is possible if this part of `ModularServer`'s `__init__` ```python self.js_code = [] for element in self.visualization_elements: for include_file in element.package_includes: self.package_includes.add(include_file) for include_file in element.local_includes: self.local_includes.add(include_file) self.js_code.append(element.js_code) ``` is...