rht

Results 789 comments of rht

What is the difference between the IBL and non IBL version? Would be informative to have this in the documentation.

Before this PR is merged, it would be good to squash all the commits into 1 commit, so that the main branch has a clean commit history.

This is the error cause: https://github.com/projectmesa/mesa/runs/4572515781?check_suite_focus=true#step:6:132. PyIBL is not installed when running. Would it take a long time to `pip install pyibl`? There hasn't been any examples that require extra...

Yes, you should remove `pyibl` from requirements.txt, and I assume you will add the install guide of PyIBL in the README. Additionally, you should modify after this line: https://github.com/projectmesa/mesa/blob/cda0495a4c7ca9656cbefd393d9a085b7cbf3367/tests/test_examples.py#L20 to...

This is the remaining TODO: https://github.com/projectmesa/mesa/pull/1057#issuecomment-998398395. Otherwise the tests are broken. The test breaks because the El Farol example still imports from `pyibl`. The solution is to exclude the El...

If the lint problems are specific to the newly added ipynb in this PR, then you definitely should fix them.

@jackiekazil @tpike3 need your approval to run the CI again. It seems to be disabled somehow.

Those are probably from the binary files from the plot images. For now, one solution would be to exclude the .ipynb from codespell CI, but this is not ideal. Also,...

Bump. I think you should just ignore that particular ipynb from the Codespell CI. You can add the ignore path in https://github.com/projectmesa/mesa/blob/d346c4879a46052ea75884a980bcbc74fbb27766/.github/workflows/python.yml#L81. Also, the .ipynb needs to be linted with...

The diff for python.yml is too big. It seems that your code editor auto formatted it? Also, it should be just the El Farol ipynb, because we do need spell...