Richard Hansen comments

Results 196 comments of


                                            Richard Hansen

Fix textLinesMutator when dealing with insertions/deletions at the end of pad

I rebased onto latest `develop` and pushed a couple of fixup commits.

Possible page load improvements

Can we switch to webpack instead of tuning tar.json? What would it take to switch?

Possible page load improvements

ep_webpack only packs `.js` files from plugins. It doesn't touch core `.js` files. I looked at webpack a bit and it looks like a fair amount of straightforward work, except...

Installed plugins won’t appear as installed

> @rhansen Afaik you are using sqlite3, what's the correct procedure here to install sqlite3 without breaking plugins? Install sqlite3 under `src/`, not top-level.

Frontend tests should run with different window sizes

I think it's best to set `min-width` on the iframe to something large enough to avoid the wrapping. I don't think it's useful to run all of the tests a...

Hide menu_right on ReadOnly pads

Those buttons still exist for read-only pads because they could still be useful to users: export pad as HTML, visit a historical version of the pad, see list of other...

WIP: Changeset: Refactor to improve API, and other cleanups

@webzwo0i I'm going to split this PR into multiple easier-to-digest PRs. #5268 is the first of many. My preference would be to comment on those individual PRs instead of here....

Facility to prevent focus theft when embedded (in Element for example)

> Hi @JohnMcLear , which branch do we need to use for testing ? `jm-dont-focus-when-embedded` (see pull request #5173)

Etherpad still crashs when when querying stats API with timeout

There are two issues here that I'd like to address separately: 1. Etherpad shouldn't crash if a DB query throws. This should be easy to fix. 2. The query shouldn't...

Etherpad still crashs when when querying stats API with timeout

> 1. Etherpad shouldn't crash if a DB query throws. This should be easy to fix. Sigh, I jinxed myself by saying that. It's not easy to fix. IIUC, what's...