Richard Hansen
Richard Hansen
Tests: ```diff diff --git a/test/test_headers/test_http.py b/test/test_headers/test_http.py index 5983a10..739b455 100644 --- a/test/test_headers/test_http.py +++ b/test/test_headers/test_http.py @@ -30,6 +30,19 @@ def test_X_Forwarded_Proto_is_passed_on(docker_compose, nginxproxy): assert "X-Forwarded-Proto: f00\n" in r.text +##### Testing the handling of...
PR #1927 alters the behavior of the existing `X-Forwarded-Proto`, `X-Forwarded-Ssl`, and `X-Forwarded-Port` headers. This PR adds a new `X-Forwarded-Host` header. If one of these two PRs is merged, the other...
This PR needs some changes anyway (add tests) so we might as well merge #1927 first. Unless @xujif is around to make the changes I'll open a new PR for...
Thanks for updating docker-gen. I rebased and switched to the `join` function.
I updated the PR to keep the current behavior by default.
Friendly ping @buchdag
I'm not super satisfied with the tests I added, but I couldn't think of a good way to thoroughly test the feature (e.g., grepping the generated config file seems too...
Friendly ping @buchdag
It is common practice to have a "trust proxy" option in the backend server ([example](https://expressjs.com/en/guide/behind-proxies.html)). If disabled, the backend server assumes that untrusted clients might connect directly to the server....
There could be an option, but if so it should default to overwriting the client-supplied values for safety. The only legitimate use case for allowing client-supplied values is if there...