Richard Hansen
Richard Hansen
> Does it provide any advantage / behaviour change when not using `VIRTUAL_PATH` ? Yes. Currently, if a single container is used for multiple vhosts (e.g., `VIRTUAL_HOST: foo.example,bar.example`) then multiple...
@buswedg That message can be ignored. See: https://github.com/nginx-proxy/docker-gen/pull/494
Marking as draft until #2127 is merged.
> I think we should stick to environment variables unless we're prepared to migrate everything to labels, as we don't use labels for anything yet. I also believe that people...
@buchdag I'm not sure. There are pros and cons either way. I opened #2148 so we can discuss it further.
> What would be needed to confirm that it work as intended ? Time, or discussions/bug reports. We don't have a way of collecting usage statistics, so there's not much...
> keepalive is not experimental Agreed; the experimental thing here is the *ability to enable* keepalive in `nginx-proxy`, not keepalive itself. > I do like the way of this implementation...
> I suspect there is a problem setting the `proxy_set_header Connection $proxy_connection_noclose;` in the location block. Good catch, thank you @SchoNie! > Maybe a better way would be to wrap...
Yes, it was.
See for additional alternative approaches.