ether
WIP: Changeset: Refactor to improve API, and other cleanups
DO NOT MERGE: This will be split into multiple smaller pull requests to make things easier to review.
The code in Changeset.js had lots of readability problems so I spent some time trying to clean it up. There shouldn't be any behavior change.
cc @webzwo0i
Sorry for the late response! This is great work.
Should I cherry-pick some of the commits into new PRs or should I write my comments here? Might get messy fast...
I think having https://github.com/ether/etherpad-lite/issues/5267 would be really useful here
@webzwo0i I'm going to split this PR into multiple easier-to-digest PRs. #5268 is the first of many. My preference would be to comment on those individual PRs instead of here.
I think having #5267 would be really useful here
Agreed, though I don't think it should block this work.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.