Ricardo Amaral

Results 150 comments of Ricardo Amaral

Is it possible to ignore wildcard domains? Adding `*.example.com` doesn't seem to be working :(

> [!IMPORTANT] > I'm not a Tiptap maintainer, just someone that cares about it. Opinions are my own, and not the views of Tiptap maintainers. Relying on code order execution...

> and if we were to increase Blockquote's `priority` directly in `starter-kit`, this might cause other users' custom extensions to no longer override blockquote from the starter-kit. I personally don't...

> I agree, but I doubt TipTap is going to make a breaking release/major version bump to fix such a minor bug. I don't see why not. If it's a...

There's one test failing, `allows images to be added via URL`, but it looks a flaky one, since I had this passing before in this PR, and fail in a...

> LGTM! Just a quick question regarding the `tokenize` function. It says it's an external function only - but I still assume it's safe to use? Yes, it should be...

@C-Hess This was [implemented before](https://github.com/ueberdosis/tiptap/pull/2282) but reverted because it doesn't work with SSR. You may want to go through that PR discussion, and perhaps find a solution that doesn't break...

Awesome, thanks :) Will you reference this issue when committing so I can keep track of the progress? Doing something that depends on fixing this and would love to know...

> I'll show 7.1 in "normal" channels + the "X" part in another line as I do now with Dolby Atmos, for more coherency. Thinking about this, I'm a little...

I'm also getting this and I'm not using Kotlin at all: > :app:compileDebugJavaWithJavac > advice defined in hugo.weaving.internal.Hugo has not been applied [Xlint:adviceDidNotMatch](...) > :app:assembleDebug