Rez
Rez
@lesliecdubs - how do you feel about bringing this into PRC planning?
Initial investigation: Had some difficulty with narrowing down an actual fix. Simply stopping propagation on the escape handler in AnchoredOverlay doesn’t work, as the escape handler doesn’t get called /...
Thanks @siddharthkp - just a heads up for anyone waiting on this fix - it will ship as part of https://github.com/primer/react/pull/1825
We think it would be sensible to remove the dependency on react-router from Primer altogether. Would you agree @mattcosta7? If so, `activeClassName` setting would be removed during that process. This...
👋 Coming in a bit late here, sorry 😅 ... Just wanted to mention that I have visual regression testing on Storybook interactions working in Primer Brand. Both done through...
Thanks for filing this @simurai ❤ Potential solutions: - Implement small Buttons for consistency with other, newer nav patterns (SubNav) - Add short title option We generally discourage long CTA...
cc. @danielguillan, @jesussandreas and @simmonsjenna for initial feedback on how much of this should upstreamed to the core library.
👋 @sergioalvz - thanks for opening this issue. Is there a need to set `"false"` here instead of `undefined`? Per MDN guidance, you only need to set the aria-current attribute...
Related to https://github.com/primer/brand/issues/514
Status update: PR is blocked on this new, related but ultimately blocking request: https://github.com/github/primer/issues/3290