brand icon indicating copy to clipboard operation
brand copied to clipboard

Add logosuite

Open rezrah opened this issue 1 year ago • 4 comments

Summary

Adds logosuite to f2 template

🔗 See slack for full details

Resolves https://github.com/github/primer/issues/3098

List of notable changes:

  • adds logosuite to F2 templates

What should reviewers focus on?

  • Verify correct placement and surrounding placement

Contributor checklist:

  • [ ] All new and existing CI checks pass
  • [ ] Tests prove that the feature works and covers both happy and unhappy paths
  • [ ] Any drop in coverage, breaking changes or regressions have been documented above
  • [ ] New visual snapshots have been generated / updated for any UI changes
  • [ ] All developer debugging and non-functional logging has been removed
  • [ ] Related issues have been referenced in the PR description

Reviewer checklist:

  • [ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • [ ] Check that tests prove the feature works and covers both happy and unhappy paths
  • [ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

🔗 See slack for full details

rezrah avatar Apr 25 '24 13:04 rezrah

⚠️ No Changeset found

Latest commit: 9aec14949e0bf948fd60329f67be2b2ce8780bad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 25 '24 13:04 changeset-bot[bot]

🟢 No design token changes found

github-actions[bot] avatar Apr 25 '24 13:04 github-actions[bot]

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

github-actions[bot] avatar Apr 25 '24 13:04 github-actions[bot]

Status update: PR is blocked on this new, related but ultimately blocking request: https://github.com/github/primer/issues/3290

rezrah avatar Jun 17 '24 13:06 rezrah