Rez

Results 56 comments of Rez

@pouretrebelle option 2 is also a good shout, because the nav shouldn't be collapsing when the adjacent space is clearely available. If it's not too much work, could you please...

👋 @sergioalvz - thanks for the request. We explored deeplinks a little while back, which sounds similar to what you're asking about. The feature lost traction due to lowered prioritisation,...

Update: We've moved this into our backlog, and will use [this issue as the source of truth](https://github.com/github/primer/issues/1749) going forward

I can see a change to the visual snapshot but wonder if that should have changed here? 🤔 Can't leave an inline comment so FYI @joshfarrant

Hi @joshfarrant, just going through open PRs and wanted to get back to you (sorry for delay). It's a neat idea, but I'm reluctant to add this to Storybook because...

@joshfarrant can you share the px value you used for the narrow viewport please? Was it arbitrary of mapping to our `narrow` Primer Brand breakpoint?

> and set any sufficiently long string as the current page I'm wondering what the use-case is for this? ☝ We discourage long strings (like full sentences) in this component,...

- Wrapping was discussed the during design phase but doesn't easily work for multiple reasons. A notable one being that we'll end up with a problematic and duplicative open state....

Related issue: https://github.com/github/primer/issues/5147

Closing out as reflow is now possible using the new [subheading](https://stunning-chainsaw-j82glqz.pages.github.io/?path=/story/components-subnav-features--sub-heading), but not planned for normal links