core icon indicating copy to clipboard operation
core copied to clipboard

[Epic] Convert to monorepo

Open rekmarks opened this issue 5 years ago • 3 comments

By iterating in the approval controller, I've bumped us up two major versions, and with #321, it will be a third. We should publish all controllers as individual packages, and turn this into a monorepo.

rekmarks avatar Dec 17 '20 08:12 rekmarks

When using a monorepo, my preferred practice for packages is to keep the versions linked so that there is never a discrepancy in version number across packages. React, and babel are good examples of this. I don't think we want our controllers in different version states; thus, it might not solve the particular problem stated in the description.

brad-decker avatar Dec 17 '20 15:12 brad-decker

~This would also require a significant rethinking of the messaging proposal to have each controller in its separate package.~

this is already necessary, but the original comment stands. :D

brad-decker avatar Dec 17 '20 16:12 brad-decker

Converting this repo into a monorepo (with all controllers placed into their own package) is now a goal of the newly established core team and it is something we will be aiming to complete by end of Q2.

As it relates to the discussion above, we have decided that we do not want to synchronize versions among all of the packages in this repo. Eventually, this repo will be renamed core and will house other packages which are not related to controllers. We want to be able to give ourselves and product teams the independence to maintain packages with as little coupling as possible.

Consult this document for more information on our plan going forward.

mcmire avatar Mar 31 '22 19:03 mcmire

This was completed in https://github.com/MetaMask/core/pull/831

Gudahtt avatar Jan 19 '23 16:01 Gudahtt