Erik Marks

Results 79 issues of Erik Marks

For some time, Jest has been complaining about unfinished async operations when tests end. The recommended way to understand what those operations are is the `--detectOpenHandles` flag, which is broken...

bug
team-wallet-framework

In JavaScript / TypeScript, this package will strip not just the block comment but the entire remainder of the string when a block comment of the form `/**/` is encountered....

Errors are "serialized" using the `serializeError` function, and this function has considerable issues. We use the internal utility `isValidCode` which only returns `true` if this package has a message for...

bug

Add the latest `@metamask/eslint-config` packages and a config matching the module template.

Replace `tape` with `jest` per the MetaMask module template, and colocate tests with source files.

Remove CircleCI (ask an admin to disable it on their end), add / fix `CHANGELOG.md` file for `auto-changelog` compatibility, add GitHub actions per module template.

Deprecate `eth-rpc-errors` and rename this package to `@metamask/errors`.

#### Description of Change The `DEPS` file states that Electron is on Node.js ^16.x. I am guessing that the PR bumping to Node.js 16 overlooked the `.nvmrc` file, which is...

new-pr 🌱

Ref: #138 ## Problem Once a CAIP-25 request has succeeded, nothing stops the dapp from making successive CAIP-25 requests with different methods, events, chains, and namespaces. For completeness, the specification...

Ref: #138 ## Problem CAIP-25 currently does not mention anything about the length of time for which a handshake persists, or what we may call "sessions". Should CAIP-25 specify some...