rejeb ben rejeb
rejeb ben rejeb
Thank you for the review, Juste a question please, I have a doubt, whith "new behavior" you mean having column family name in spark dataframe column name ?
I agree with you, the patch is to fix the issue but also to document the new behavior and add more flexibility in using the spark-phoenix connector. Please let me...
Done, thank you for the review.
I added tests for datasource v1 when I've been working on PHOENIX-6783 because there has been no tests before that. I did that by duplicating all tests in `PhoenixSparkIT` and...
I added steps in github action workflow to generate test reports. The steps has failed with error "Error: HttpError: Resource not accessible by integration". @stoty, can you please check. I...
> I have not forgotten about this, but I need to take care of some higher priority stuff first. I got some free time this weekend so I wanted to...
- Removed old V1 test class since all exists in `PhoenixSparkIT` so code is correctly tested. - Added a news class to help with review, with significant tests for source...
> Regarding the savemode changes: How do other Spark SQL connectors handle Append/Overwrite ? Do you think that accepting both is a good practice ? Many connectors handle both Append/Overwrite....
> Please fix the Yetus errors, especially the missing ASF licenses. @stoty, done.
> > Overwrite mode have'nt been implement respecting Spark definition for this mode. > > What would the expected behaviour be ? It should truncate table and then insert data....