phoenix-connectors
phoenix-connectors copied to clipboard
apache
PHOENIX-7407 Remove deprecated datasource V1 code from spark2 and spark3 connector
Removed datasource V1 classes.
Since "org.apache.phoenix.spark" uses datasource V2 implementation there is no need to keep all tests in PhoenixSparkDatasourceV1IT. I only kept necessary tests because others are duplication of the ones in PhoenixSparkIT.
I added addtional steps in github action to generates tests reports details.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 28s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 14m 28s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 7s | root in master failed. |
| -1 :x: | checkstyle | 0m 30s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 7s | root in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 6s | root in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 6s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 7s | root in the patch failed. |
| -1 :x: | javac | 0m 7s | root in the patch failed. |
| -1 :x: | scalac | 0m 7s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 17s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 0s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 6s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 6s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 24s | The patch generated 8 ASF License warnings. |
| 25m 50s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux c4a39340c9c6 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 8adb127 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/1/console |
| versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
-
There seems to a significant amount test boilerplate refactoring here. Can you split that to a different JIRA/PR ?
-
Shouldn't the tests using the V1 API be kept, so that the backward compatibility code is properly exercised ?
I added tests for datasource v1 when I've been working on PHOENIX-6783 because there has been no tests before that.
I did that by duplicating all tests in PhoenixSparkIT and changed the .format("phoenix") to .format("org.apache.phoenix.spark").
Now both .format() uses datasource V2 implementation so all these tests are duplication and will just exercice same code 2 times. IMO, there is no need to keep them because all ests exists in PhoenixSparkIT.
I kept a some tests to valide thatthe use of .format("org.apache.phoenix.spark") works.
For deprecated methods phoenixTableAsDataFrame, phoenixTableAsRDD and saveToPhoenix I added some test cases.
I added steps in github action workflow to generate test reports. The steps has failed with error "Error: HttpError: Resource not accessible by integration". @stoty, can you please check. I tested this steps on my fork and it worked.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 43s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 14m 6s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 9s | root in master failed. |
| -1 :x: | compile | 0m 6s | root in master failed. |
| -1 :x: | checkstyle | 0m 29s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 6s | root in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 6s | root in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 7s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 7s | root in the patch failed. |
| -1 :x: | javac | 0m 7s | root in the patch failed. |
| -1 :x: | scalac | 0m 7s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 17s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 1s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 6s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 6s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 24s | The patch generated 8 ASF License warnings. |
| 25m 41s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux 74b7cedaa7e9 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / b29e6a5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/2/console |
| versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 14m 8s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 6s | root in master failed. |
| -1 :x: | checkstyle | 0m 30s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 6s | root in master failed. |
| -1 :x: | scaladoc | 0m 10s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 6s | root in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 6s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | root in the patch failed. |
| -1 :x: | scalac | 0m 6s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 17s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 1s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 6s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 7s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 24s | The patch generated 8 ASF License warnings. |
| 19m 33s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux aeca502d7245 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / b29e6a5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/3/console |
| versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 14m 42s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 7s | root in master failed. |
| -1 :x: | checkstyle | 0m 31s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 6s | root in master failed. |
| -1 :x: | scaladoc | 0m 10s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 6s | root in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 6s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | root in the patch failed. |
| -1 :x: | scalac | 0m 6s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 16s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 1s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 6s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 6s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 25s | The patch generated 8 ASF License warnings. |
| 20m 9s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux cca4f4e05542 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / b29e6a5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/4/console |
| versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
I have not forgotten about this, but I need to take care of some higher priority stuff first.
I have not forgotten about this, but I need to take care of some higher priority stuff first.
I got some free time this weekend so I wanted to test something. Please do not mind about future pushes, I will post a message when I finish updates.
I will create a new class with kept and added tests for V1 and helper methods then remove old class to make review easier.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 25s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 14m 1s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 6s | root in master failed. |
| -1 :x: | checkstyle | 0m 30s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 6s | root in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 6s | root in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 6s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | root in the patch failed. |
| -1 :x: | scalac | 0m 6s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 17s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 0s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 6s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 6s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 24s | The patch generated 8 ASF License warnings. |
| 25m 21s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux 1926ceb2c637 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 6a5f621 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/5/console |
| versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 13m 46s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 6s | root in master failed. |
| -1 :x: | checkstyle | 0m 30s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 10s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 6s | root in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 6s | root in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 6s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 7s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | root in the patch failed. |
| -1 :x: | scalac | 0m 6s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 17s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 0s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 7s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 7s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 24s | The patch generated 8 ASF License warnings. |
| 19m 10s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux ee5680ea03cc 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 6a5f621 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/6/console |
| versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 26s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 13m 56s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 9s | root in master failed. |
| -1 :x: | compile | 0m 6s | root in master failed. |
| -1 :x: | checkstyle | 0m 29s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 7s | root in master failed. |
| -1 :x: | scaladoc | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 7s | root in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 6s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 7s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | root in the patch failed. |
| -1 :x: | scalac | 0m 6s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 17s | The patch fails to run checkstyle in root |
| -1 :x: | markdownlint | 0m 4s | The patch generated 3 new + 134 unchanged - 1 fixed = 137 total (was 135) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 1s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 7s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 6s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 24s | The patch generated 8 ASF License warnings. |
| 25m 20s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile markdownlint spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux cc2080fa0178 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 6a5f621 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/7/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
- Removed old V1 test class since all exists in
PhoenixSparkITso code is correctly tested. - Added a news class to help with review, with significant tests for source "org.apache.phoenix.spark" and tests for deprecated functions.
- Updated read me to mention that "org.apache.phoenix.spark" now uses DatasourceV2.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 13m 56s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 6s | root in master failed. |
| -1 :x: | checkstyle | 0m 30s | The patch fails to run checkstyle in root |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | javadoc | 0m 6s | root in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 6s | root in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 6s | root in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | root in the patch failed. |
| -1 :x: | scalac | 0m 6s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 16s | The patch fails to run checkstyle in root |
| -1 :x: | markdownlint | 0m 2s | The patch generated 3 new + 134 unchanged - 1 fixed = 137 total (was 135) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| -1 :x: | yamllint | 0m 1s | The patch generated 7 new + 3 unchanged - 0 fixed = 10 total (was 3) |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javadoc | 0m 6s | root in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 7s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| -1 :x: | asflicense | 0m 24s | The patch generated 8 ASF License warnings. |
| 19m 22s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml compile markdownlint spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux 2fd4e047883a 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 6a5f621 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/buildtool-branch-checkstyle-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/branch-spotbugs-root.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-compile-root.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| yamllint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/diff-patch-yamllint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-javadoc-root.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-scaladoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/8/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 10s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 2m 22s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark3 in master failed. |
| +1 :green_heart: | checkstyle | 0m 28s | master passed |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | compile | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javac | 0m 8s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scalac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scalac | 0m 8s | phoenix5-spark3 in the patch failed. |
| +1 :green_heart: | checkstyle | 0m 8s | phoenix5-spark: The patch generated 0 new + 5 unchanged - 2 fixed = 5 total (was 7) |
| -1 :x: | checkstyle | 0m 8s | phoenix5-spark3: The patch generated 4 new + 7 unchanged - 2 fixed = 11 total (was 9) |
| -1 :x: | markdownlint | 0m 4s | The patch generated 3 new + 134 unchanged - 1 fixed = 137 total (was 135) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | unit | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | asflicense | 0m 16s | The patch generated 8 ASF License warnings. |
| 13m 7s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile markdownlint spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux fd353d00336d 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / b1ac7e8 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/9/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 8s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 2m 26s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark3 in master failed. |
| +1 :green_heart: | checkstyle | 0m 28s | master passed |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in master failed. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scalac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scalac | 0m 9s | phoenix5-spark3 in the patch failed. |
| +1 :green_heart: | checkstyle | 0m 8s | phoenix5-spark: The patch generated 0 new + 5 unchanged - 2 fixed = 5 total (was 7) |
| -1 :x: | checkstyle | 0m 8s | phoenix5-spark3: The patch generated 4 new + 7 unchanged - 2 fixed = 11 total (was 9) |
| -1 :x: | markdownlint | 0m 4s | The patch generated 3 new + 134 unchanged - 1 fixed = 137 total (was 135) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | unit | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | asflicense | 0m 15s | The patch generated 7 ASF License warnings. |
| 13m 13s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/145 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile markdownlint spotbugs hbaseanti checkstyle scalac scaladoc |
| uname | Linux 0dcb5dcd40ac 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 09afb21 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt |
| scalac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt |
| scaladoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 47 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-145/10/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
Regarding the savemode changes: How do other Spark SQL connectors handle Append/Overwrite ? Do you think that accepting both is a good practice ?
Regarding the savemode changes: How do other Spark SQL connectors handle Append/Overwrite ? Do you think that accepting both is a good practice ?
Many connectors handle both Append/Overwrite. The issue here is that the Overwrite mode have'nt been implement respecting Spark definition for this mode. In order to not breakup old application that still use V1, the behavior of Overwrite cannot be changed. Other option will be to remove it, but it will require small change for old applications to update their code and Append instead of Overwrite.
Please fix the Yetus errors, especially the missing ASF licenses.
@stoty, done.
Overwrite mode have'nt been implement respecting Spark definition for this mode. What would the expected behaviour be ?
Overwrite mode have'nt been implement respecting Spark definition for this mode. What would the expected behaviour be ?
It should truncate table and then insert data. IMO, we should not change actual behavior because it might cause data loss for apps still using the old version and unaware of this change.
It should truncate table and then insert data. IMO, we should not change actual behavior because it might cause data loss for apps still using the old version and unaware of this change.
Thanks. That's definitely not something we want the connector to do. Can we log something at INFO when truncate is specified ?
Also there are still a few unused imports and similar Yetus warnings. Can you clean those up ?
It should truncate table and then insert data. IMO, we should not change actual behavior because it might cause data loss for apps still using the old version and unaware of this change.
Thanks. That's definitely not something we want the connector to do. Can we log something at INFO when truncate is specified ?
Yes, we can log something at INF., In this PR, I kept the actual behavior for Overwrite it means that it will not do the truncate before inserting data.
Yes, we can log something at INF., In this PR, I kept the actual behavior for Overwrite it means that it will not do the truncate before inserting data.
That's good. Just log something like "Overwrite mode specified. Ignoring Overwrite and treating it as Append."
Please also fix the whitespace and codestyle issues reported by Yetus.
@stoty, how can I run the checks that Yetus do before pushing to repository. I did a rebase on master and pushed then I lost information about Yetus issues. I have to wait next Yetus run.
@stoty, how can I run the checks that Yetus do before pushing to repository. I did a rebase on master and pushed then I lost information about Yetus issues. I have to wait next Yetus run.
Not easily. Most of them, like spotless and spotbugs can be simply run from maven, but Yetus does some postprocessing on the results to filter out the entries for unchanged files.
In theory you can also run Yetus locally, but setting that up is a big task, I would not recommend that (unless you plan to work on Yetus support)
@stoty, how can I run the checks that Yetus do before pushing to repository. I did a rebase on master and pushed then I lost information about Yetus issues. I have to wait next Yetus run.
Not easily. Most of them, like spotless and spotbugs can be simply run from maven, but Yetus does some postprocessing on the results to filter out the entries for unchanged files.
In theory you can also run Yetus locally, but setting that up is a big task, I would not recommend that (unless you plan to work on Yetus support)
Thanks, I'll wait for report instead.