Reid Baker

Results 307 comments of Reid Baker

Packages now has the ability to mark steps as infra steps and a new command to download dependencies is called and marked is infra. I need to audit framework for...

@lubritto is there anything we can do here to get this reviewed?

@jason-simmons the android team is picking this back up. Other than downgrade skia is there something else we should do to fix this bug?

Is this test https://github.com/flutter/flutter/blob/4342887826c24197d66192a2733bc2fbf968aa85/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart or https://github.com/flutter/flutter/blob/4342887826c24197d66192a2733bc2fbf968aa85/dev/devicelab/lib/tasks/native_assets_test.dart

I tried looking at both of those tests and I could not quickly find where their gradle memory setting are coming from. I see `-XX:MaxMetaspaceSize=2G` in the logs so My...

In that case you are getting the values from the create template which has the latest values. The naive solution is to increase the heap space yet again but I...

> > I thought create all packages ran as part of presubmit and would have been caught before we merged the kts migration. > > I assume that was a...

There are still references in this codebase https://github.com/search?q=repo%3Aarthenica%2Fffmpeg-kit%20(%22io.flutter.view.FlutterMain%22%20OR%20%22io.flutter.view.FlutterNativeView%22%20OR%20%22io.flutter.view.FlutterView%22%20OR%20%22io.flutter.embedding.engine.plugins.shim%22%20OR%20%22io.flutter.app%22%20OR%20%22PluginRegistry.Registrar%22)%20&type=code Current forecast is to remove these classes shortly after the flutter 3.27 release is cut.

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...

@justinmc assigning back to you based on my understanding of the split between you and @gmackall. P1 is still correct because android 16 will have predictive back on by default.