Reid Baker

Results 303 comments of Reid Baker

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...

Updating to master and rerunning to see if the failure repetes. Looking at the past 100 or so runs I saw 2 failures but I think they were on pull...

> `ktlint` wants this block of code: > > ```kotlin > pluginManagement { > val flutterSdkPath = run { > val properties = java.util.Properties() > file("local.properties").inputStream().use { properties.load(it) } >...

This file initally had me report this issue but I believe this is a generated file. https://github.com/kalismeras61/flutter_page_transition/blob/master/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java Searching with https://github.com/search?q=repo%3Akalismeras61%2Fflutter_page_transition+%28%22io.flutter.view.FlutterMain%22+OR+%22io.flutter.view.FlutterNativeView%22+OR+%22io.flutter.view.FlutterView%22+OR+%22io.flutter.embedding.engine.plugins.shim%22+OR+%22io.flutter.app%22+OR+%22PluginRegistry.Registrar%22%29+&type=code shows no references to the classes we are removing. I...

@ziperjohn @msayed-net is this bug a regression? if so what version of video player works correctly (so we can bisect)

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...