packages
packages copied to clipboard
[camera] Manual roll and skip failing tests
See https://github.com/flutter/flutter/issues/157181
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [ ] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [ ] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes. - [x] I updated/added relevant documentation (doc comments with
///). - [ ] I added new tests to check the change I am making, or this PR is test-exempt.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
What's the status of this? Are we planning on landing this (or something like it), or getting the roll started again blocked on the failing tests?
@stuartmorgan I reran this multiple times, but it looks like the video_player tests began failing and I wasn't able to finish investigating why.
I updated to the lasts flutter/flutter version. Will try and skip additional tests if this doesn't work.
@stuartmorgan @flutter/android-reviewers FYI
The build all packages test was failing because it looks like android/app/build.gradle moved to .../build.gradle.kts.
Changed 52 dependencies!
12 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Unhandled exception:
PathNotFoundException: Cannot open file, path = './all_packages/android/app/build.gradle' (OS Error: No such file or directory, errno = 2)
#0 _File.throwIfError (dart:io/file_impl.dart:675:7)
#1 _File.openSync (dart:io/file_impl.dart:490:5)
#2 _File.readAsBytesSync (dart:io/file_impl.dart:574:18)
#3 _File.readAsStringSync (dart:io/file_impl.dart:624:18)
#4 ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:99:16)
#5 CreateAllPackagesAppCommand._updateAppGradle (package:flutter_plugin_tools/src/create_all_packages_app_command.dart:224:39)
#6 CreateAllPackagesAppCommand.run (package:flutter_plugin_tools/src/create_all_packages_app_command.dart:109:7)
<asynchronous suspension>
#7 CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#8 main.<anonymous closure> (package:flutter_plugin_tools/src/main.dart:105:12)
<asynchronous suspension>
Edit Whoops, now new errors are popping up. Fixing the script now.
* Where:
Build file '/b/s/w/ir/x/w/packages/all_packages/android/app/build.gradle.kts' line: 10
* What went wrong:
Script compilation errors:
Line 10: compileSdk 34
^ Unexpected tokens (use ';' to separate expressions on the same line)
Line 23: multiDexEnabled true
^ Unexpected tokens (use ';' to separate expressions on the same line)
Line 28: minSdkVersion 21
^ Unexpected tokens (use ';' to separate expressions on the same line)
Line 28: minSdkVersion 21
^ Function invocation 'minSdkVersion(...)' expected
Line 28: minSdkVersion 21
^ None of the following functions can be called with the arguments supplied:
public abstract fun minSdkVersion(minSdkVersion: Int): Unit defined in com.android.build.api.dsl.ApplicationDefaultConfig
public abstract fun minSdkVersion(minSdkVersion: String?): Unit defined in com.android.build.api.dsl.ApplicationDefaultConfig
Line 48: implementation 'androidx.lifecycle:lifecycle-runtime:2.2.0-rc01'
^ Unexpected tokens (use ';' to separate expressions on the same line)
Line 48: implementation 'androidx.lifecycle:lifecycle-runtime:2.2.0-rc01'
^ Unresolved reference. None of the following candidates is applicable because of receiver type mismatch:
public val NamedDomainObjectContainer<Configuration>.implementation: NamedDomainObjectProvider<Configuration> defined in org.gradle.kotlin.dsl
I thought create all packages ran as part of presubmit and would have been caught before we merged the kts migration.
I assume that was a flutter/flutter change? The only flutter/packages test we run in flutter/flutter is Dart analysis.
I thought create all packages ran as part of presubmit and would have been caught before we merged the kts migration.
I assume that was a flutter/flutter change? The only flutter/packages test we run in flutter/flutter is Dart analysis.
Ah you are right, I reviewed that framework pr from bartek then worked with jesswrd on a packages pr and my brain mixed them up. Also her pr has not landed. Either way sorry for the breakage as we migrate to kotlin code in more places.
Either way sorry for the breakage as we migrate to kotlin code in more places.
The surgery we do to the project in create-all-packages is inherently fragile; it's totally expected that it would break from time to time and we'd need to fix it in rolls.