Reid Baker

Waiting on one more approver from the engine team then we can merge.

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...

@AmolGangadhare is there anything I can do here to get this reviewed?

You might choose to leave the definition of this flag around for another release where the flag does nothing since this flag is an opt in to the new behavior...

I am not. I filed bugs against the top 1000 "most popular" plugins that had v1 embedding references. This is more than 50 plugins down my list so I likely...

[Here are the references](https://github.com/search?q=repo%3Aaagarwal1012%2FLiquid-Pull-To-Refresh%20(%22io.flutter.view.FlutterMain%22%20OR%20%22io.flutter.view.FlutterNativeView%22%20OR%20%22io.flutter.view.FlutterView%22%20OR%20%22io.flutter.embedding.engine.plugins.shim%22%20OR%20%22io.flutter.app%22%20OR%20%22PluginRegistry.Registrar%22)%20&type=code). The good news is they are only in the example app which means customers (aka plugin users) will likely not be affected. Also it is probably...

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...

https://github.com/flutter/engine/pull/52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To...

We should not be fetching dependencies as part of our CI. I am not familiar with this code but it is something my team can make sure gets fixed. ```...

Links and resources that might be helpful I think this is the test that failed. https://github.com/flutter/engine/blob/main/shell/platform/android/test/io/flutter/plugin/localization/LocalizationPluginTest.java Luci python file https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/engine.py Command that failed to find any mention of localization plugin...