Results 358 comments of Takatoshi Kondo

Unfortunately, 10 layers nested class is very unusual usecase for me. For that usecase, I don't accapt library modification. Again, `olda::type` and `newa::type` is unreleated in general. You can write...

I considered again. I think that your 10 layers nested case is still unusual for me, but is there other general usecase ? I come up withe something like this:...

I noticed that bigger impact modification is requried: The adaptors take user type as template parameters (typically `T`) should propagate `hint`. For example, `std::vector`. https://github.com/msgpack/msgpack-c/blob/1edfba0cd24378bba74578f18ca96e3809ae1664/include/msgpack/v1/adaptor/vector.hpp#L30-L40 should modify as follows: ```cpp...

I am no sure but some of implementation defined type would cause the issue, I guess. You can write your own adaptor using the following way: https://github.com/msgpack/msgpack-c/wiki/v2_0_cpp_adaptor#non-intrusive-approach Perhaps writing your...

NOTE: I tried to apply clang-format at Apr 2022 at other project. See https://github.com/redboltz/mqtt_cpp/pull/927#discussion_r846594115 At that time, lambda capture list and template `` adjustment is not enough for me. I...

Yes, clang-format 's template parameter formatting and lambda related formatting is not enough for me. Unfortunately, I don't have much time to treat the clang-format but if you or someone...

Thank you for reporting this issue. The change was introduced in pull request #1018, which addresses issue #1017 that explains the rationale behind this update. This update was implemented in...

When msgpack-c(C++) receives EXT format family MessagePack formatted byte stream, msgpack-c creates `msgpack::object` and its type is `msgpack::type::EXT`. See https://github.com/msgpack/msgpack-c/wiki/v2_0_cpp_object You can access `msgpack::object` directly as follows: https://github.com/msgpack/msgpack-c/blob/ac062e28cbf80db345800b6e113dea8ab0055499/test/msgpack_basic.cpp#L328 Or you...

I recommend that create a simple code (no MAP, no AMQP). That is focused on msgpack EXT only like the test code I mentioned. And confirm the simple code works...

It seems that sCI reports errors. Could you fix it? Maybe zlib version updating required.