Takatoshi Kondo

> Right now we have a very large amount of functionality bundled into the same class, and I think we could enhance understandability by breaking this class into two parts....

I'd like to allow to user both async/sync API call from the same endpoint object. Boost.Asio support it. I don't want to limit it on the upper layer, mqtt_cpp. It...

> > I'd like to allow to user both async/sync API call from the same endpoint object. Boost.Asio support it. I don't want to limit it on the upper layer,...

I wrote the design decision introducing Sync and Async client. https://github.com/redboltz/mqtt_cpp/pull/208#issuecomment-480594751 > ## Why don't you create asnyc_client and sync_client as the base classes of client? > * It requires...

Thank you. > - The file is difficult to navigate, making it hard to understand how things work. It's just a huge maze. > - Functionality is very closely intertwined,...

Hi @ropieur , I noticed that interesting behavior. See https://wandbox.org/permlink/9yxoG5EasqU9JZ2r If my_shared_ptr's copy constructor is deleted, then compile error occurs. If my_shared_ptr's copy constructor is defined, no compile error occurs...

I don't know why `std::any` prohibits move only types. Maybe there is a deep reason. I'm not sure these kind of hack is safe or not. But I don't find...

I noticed that the life_keeper is copied internally. See https://github.com/redboltz/mqtt_cpp/blob/69ee912408eedf9023840f7720a407acd867c66c/include/mqtt/endpoint.hpp#L12657 So we cannot use hacked_sbuffer approach. It causes assertion fail. We need to use shared_ptr but reference count operation happens...

See also https://stackoverflow.com/questions/57923561/move-only-type-adapting-stdany-with-dummy-copy-constructor-is-safe

Properties are usually used as aggregation. `variant` is based on value semantics. So I directly place the property value as follows: https://wandbox.org/permlink/vwJqrzzFQUsrq8Qa If your inherit approach means virtual function based...