Results 358 comments of Takatoshi Kondo

I don't say that basic_publish_message should always maintain the lifetime by itself. The lifetime can be managed by outside code such as life_keeper as follows: https://github.com/redboltz/mqtt_cpp/blob/8f2fa503f11eb6b52b94b55727c7aecb2046b1fe/include/mqtt/endpoint.hpp#L2139 https://github.com/redboltz/mqtt_cpp/blob/8f2fa503f11eb6b52b94b55727c7aecb2046b1fe/include/mqtt/endpoint.hpp#L8652 It is good...

It is off topic that I noticed there are some other issues that I don't respond yet. I don't have much time due to the debug our broker. Sorry about...

Thank you for the comment. I am still very busy so I didn't deeply consider yet. But I understand that the following things: 1. Current status of the lifetime is...

What part of MQTT message is encoded by protobuf? |part|example|description| |---|---|---| |string|connect client id, publish topic name|must be UTF-8| |binary|publish payload|no problem| Even if you use string, if you don't...

For your information: Here is an example that encoding MessagePack (msgpack). https://github.com/msgpack/msgpack-c Payload can be encoded as binary. ```cpp // Copyright Takatoshi Kondo 2019 // // Distributed under the Boost...

I think that if user tries to send unsubscribe with empty topics then `throw protocol_error()` is good. From the server side, if unsubscribe packet that has empty topics then `call_protocol_error_handlers()`...

Yes but v3.1.1's unsuback is not error. I sum up as follows: |version|subscribe|unsubscribe|suback|unsuback| |---|---|---|---|---| |v3.1.1|x|x|x|- (no payload)| |v5|x|x|x|x| x: empty payload is protocol error.

Yes. The earlier version of mqtt_cpp use test.mosquitto.org for test. I added UUID prefix to topic and client id to avoid conflict. However, test.mosquitto.org is not good for CI. It...

> My suggestion in this case was to install mosquito server inside the ci environment. And run it locally. Yes. That is I mentioned "We can run mosquitto on CI...

@jmin911 , thank you for the comments. I'm new to vcpkg. I think that it is good that mqtt_client_cpp supports vcpkg. I just glanced GitHub.com/Microsoft/vcpkg. But I don't understand how...