Ryan Curtin

Results 312 comments of Ryan Curtin

(I should also add: I didn't actually review the code itself yet. I briefly looked at the tests. Once we figure out the way the class should look and what...

I'd like to keep this one open---this is an important issue that does need to be fixed at some point.

Don't forget to add documentation to `doc/`. Without documentation nobody will ever know about these features.

@beny-bee @zoq does anything else need to be done here? It looks to me like this one is pretty much ready to go, but I don't know the state of...

I pushed one more changes for the "CMA-ES" name changes to the documentation. Otherwise, I think this is ready for merge so I'll merge once there is a green build.

Nice, everything is handled here and I think this is ready to go once we get it to pass the builds. I noticed that the `IQN_LogisticRegressionFunction - arma::fmat` test is...

We'll need to get the FP16 PR merged to fix some of the tests before a release, but, really great to finally get this in!

Awesome! It will be a little while until I can get to a review here. Don't worry about the cross-compilation build; it is a Raspberry Pi in my house that...

Since this is so close, we should keep it open to get it merged. I marked it keep-open

Can you fix the issues in the build before I review? I'm not sure how many changes will be needed there and since this is a fairly large PR I...