Ryan Curtin
Ryan Curtin
Nice contribution @Patschkowski! I haven't had a chance to review this yet but should get to it ~midweek this week.
@Patschkowski happy to pick this one back up if you have time. :+1:
Awesome, thanks for working on this! I'll try and take a look soon. I see the title references a binding, but this is just a C++ class for `GradientBoosting`. That's...
Hey @TirelessClock, hope things are well... this one fell off my radar a little bit, but if you have a chance to handle the rest of the comments we can...
> > I agree that these are important fixes that help clean up the codebase. But in general it's not possible to apply an automatic tool to our entire codebase...
Yep, thank you so much for your responses to each comment. I know it was tedious, but I think we have a better codebase in the end. :rocket:
Awesome that the custom reduction worked! That really simplifies the changes. Do you think you would be up for opening a PR to make that change to use a custom...
I think we need to think deeply about the API we want to provide to users if we do this. If I quantize an `FFN` to use int8 weights, then...
Yeah, I think I can agree with most of this. Here are the changes I see: * All header files from the main library to `include/` * Remove convenience includes...
Sorry, just realized I never responded to this. Yeah, that is the basic idea: the headers should move to `include/`, and we can leave other things as-is.