Ryan Curtin
Ryan Curtin
I was traveling this past week, so it took me a while to get back to, but I much appreciate the comments @shrit and @conradsnicta. The example website has been...
The documentation build fails, but only because the new website is not yet deployed. Otherwise all the links seem ok.
Agreed, the only thing is we need to look and see when we can use `fill::none`---there are some cases where it is fine to leave the memory uninitialized, as we...
Agreed, at that time it is also worth checking through the codebase for any ancient Armadillo compatibility code (sometimes it gets missed).
Thanks! That will definitely work. I wondered about the code you wrote---instead of naming the type of `arma::fill::zeros`, it just uses `decltype()` to avoid doing that. One could actually do...
Have you tried using an older version of gcc to reproduce locally? We can't expect everyone to have the newest version of the compiler. mlpack should work with any C++17...
If we are going to add a C++ class for it too, do you think you can write some documentation for it? Take a look at `doc/user/methods/decision_tree.md` for an example;...
Yeah, a switch to the existing implementation at about `x > 4` would probably do the trick for convergence too. I would be interested to see if it would be...
I also wonder if it would be possible to get additional speedup by writing a loop that the compiler can autovectorize. I doubt that `.transform()` on arbitrary lambda functions could...
Nice, the numbers look good. :+1: Two quick checks: * Does the `mnist_cnn` example still converge to the same accuracy? That is just a quick sanity check to ensure that...