Ryan Curtin

Results 312 comments of Ryan Curtin

This is definitely useful to add; a couple thoughts: * Do you think you could add information like a description for each `BOARD_NAME`? Maybe a link to relevant products (or...

@mlpack-jenkins test this please

No, I think this is a legitimate bug. I haven't had a chance to dig into the scripts that build the MSI installer. When I took a quick look, it...

Totally agreed @GLmontanari. Working on a fix in #3788 now.

@GLmontanari thanks again for the report. #3788 is ready, but not yet merged, so I mirrored the msi generated in the CI build: https://www.ratml.org/misc/mlpack-windows.msi, if you want to test it...

#3788 is merged, so I'll go ahead and close this---the next stable release will have this fixed (and that link I gave will still work too).

@IWNMWE can you be sure to add documentation to `doc/` for the new technique? Thanks :+1:

Sounds good. The only comments that matter to me before approval are: * [NSGA2 documentation change](https://github.com/mlpack/ensmallen/pull/399#discussion_r1690539090) * [indicator documentation](https://github.com/mlpack/ensmallen/pull/399#discussion_r1693168037) (just a plan for the other indicators is fine, so long...

Thanks for the clear report @Blakjak88! I opened #3958 with your suggested fixes. If you want to try that branch and see if there are any more issues, I'd appreciate...

#3958 is merged, so I will go ahead and close this. Thanks again for the report @Blakjak88!