Ruth Comer

Results 455 comments of Ruth Comer

So should I have the `get_window_extent` just return the rectangle’s window extent? It’s entirely possible that the rectangle could be placed halfway out of the main axes. I’m not sure...

> > I’m not sure why anyone would want that but that doesn’t mean that nobody will. > > What happens when the box gets dragged/can it get dragged by...

> why did the lower left and upper right segments disappear? You mean the connectors? Only 2 of those are visible by default. https://matplotlib.org/stable/gallery/subplots_axes_and_figures/zoom_inset_axes.html

I just noticed I forgot to update the deprecation warning when the patch became an artist. Now [fixed](https://github.com/matplotlib/matplotlib/compare/4d944bbf1c742d8cb7695388250c763b1df00983..b8330557540cf28bcf90ba6e30c2d5b21c846622).

Full disclosure: this is my first time doing anything in `fileformats` so, um 😨

Looks like I missed a bit 👀

My latest commit gives lbtim of 1 with @trexfeathers' code.

I think the reason this stalled was that we didn't have a reproducing example to demonstrate the problem described in the issue. So I cannot actually prove that this fixes...

I agree there is no sense keeping this open if we can no longer reproduce the problem. @arjclark do you have an opinion on this?

OK, I will close this but keep the branch in case we ever want to pick this up again.