Ruth Comer
Ruth Comer
Note that CodeCov failing is not necessarily a blocker to getting this PR merged. https://matplotlib.org/devdocs/devel/development_workflow.html#automated-tests
`get_transform` combines `get_patch_transform` which applies the height and width from the ellipse, with the standard artist `get_transform`, which returns the transform you set explicitly i.e. `transf + ax.transData`. https://github.com/matplotlib/matplotlib/blob/ba89fe42353a51b93fd69d00fde92f9cb513e3c0/lib/matplotlib/patches.py#L307-L309 `get_vertices`...
I have also tripped up on this - https://github.com/matplotlib/matplotlib/pull/29174#discussion_r1854564879 It might be worth updating the `Patch.get_transform` docstring to clarify that you get this combined transform, with a reference to `Patch.get_data_transform`...
Looks like mypy just made a new release, so I suspect we will now see the same linting errors on all PRs. You can ignore them here.