Ruth Comer

Results 454 comments of Ruth Comer

Thank you for your contribution @kyracho! I think the discussion is still ongoing in #28386 about exactly which fix is the right one, so a detailed review here will likely...

@nakamasato perhaps you are running into #1136? There is an open PR #1169 to configure the cache key.

Thank you for your contribution @aradfarahani. I think we need more information to understand the requirement for this. Could you post some example code and output to show how it...

> Edit: searching a bit more I found https://matplotlib.org/stable/api/figure_api.html#matplotlib.figure.figaspect which does the exact opposite to what I want. Maybe an option is to come up with a good name for...

Ah, I missed that `figaspect` only returns the height and width and doesn't do anything to a figure.

Currently `fill_between` returns a `PolyCollection`. If you subclass the `PolyCollection` then that subclass could have an equivalent of `make_verts` on it which could be used both in its instantiation and...

`Line2D.set_data` call its `set_xdata` and `set_ydata` methods https://github.com/matplotlib/matplotlib/blob/1e983776e9210fbc7426f28ce6e7eeadea18f9e9/lib/matplotlib/lines.py#L647-L666 So for API consistency it would make sense to have a collection that implements all three (`set_data`, `set_xdata` and `set_ydata`). I would...

Perhaps another option would be to put something in `cbook`? That has e.g. [boxplot_stats](https://matplotlib.org/stable/api/cbook_api.html#matplotlib.cbook.boxplot_stats) which is factored out of `boxplot` so you can separately do calculations and plotting.

I think * `_get_patches_for_fill` is only setting a default color if the user doesn't pass it. So that functionality is not needed within `make_verts`. * `_process_unit_info` is both telling the...