Ruth Comer
Ruth Comer
Some of the image tests failures here are maps so might be fixed by https://github.com/SciTools/cartopy/pull/2414. However, some are time vs longitude, so we can't blame Cartopy for those. I have...
The image test failures are now fixed on Matplotlib `main`. I have verified this by running the tests and gallery tests against Matplotlib's [nightly build](https://matplotlib.org/stable/install/index.html#install-a-nightly-build). The doctest failure seems to...
Added a `__getitem__` method in an effort to provide a deprecation pathway. Although `indicate_inset[_zoom]` are still marked as experimental, I suspect the pattern `box, connectors = ax.indicate_inset...` is pretty common.
Perhaps instead of inheriting from `Rectangle`, this should be a container artist with both the rectangle and the connectors as children. Then users who want more control could get hold...
> Is there an advantage to the rectangle approach/downside to making it a container? Not that I can think of. I think I just had in mind from https://github.com/matplotlib/matplotlib/issues/23424#issuecomment-1185544814 that...
OK, the `InsetIndicator` is now a container artist instead of a patch. I couldn't see which module it would obviously fit in, so made a new one. One side-effect of...
Added changenotes and directives, though I'm not sure if the behaviour change documentation for `indicate_inset[_zoom]` is really needed since these methods were marked as experimental...?
Hi @pawjast, I think that is not specific to `indicate_inset[_zoom]` but a more general problem of not being able to set separate face and edge alphas. I thought I had...
Huh. Turns out it works if you actively set `alpha=None`, but I had to study the code to figure that out....
I hid the alpha discussion because that was addressed by #28710 and is not needed for the reviewers of this PR.