Rafał Chłodnicki
Rafał Chłodnicki
> For some reason it doesn't work for me: if an LSP hover-popup is turned on, after each start of Sublime Text, this setting resets to `false` until I manually...
As I understand you want to augment the LSP result with the ST's knowledge of the symbols it has indexed. So if the LSP sees an error somewhere but ST...
Or do you just want LSP to fall back to native "go to definition" when LSP doesn't resolve to any? That could be doable.
> Source Actions should be visible, like they are right now with annotations. So you want to show them in the same way as normal code actions or in some...
Should we just add a client config option for that? What it should be named? `include_non_project_diagnostics` (defaults to `false`)? Or inverted - `ignore_non_project_diagnostics` (defaults to `true`)? Naming is the hardest...
I'm not sure if it's worth making the option so generic and make the meaning not so clear on the first look. Especially since we don't currently have any idea...
Even though I've originally raised this need, I don't think anymore that it's better to sort by location after using the current logic for a while. Nonetheless, this looks like...
@jwortmann are you fine with dropping this PR? Nobody else complained, I personally don't miss this feature either so it's probably not worth complicating the code.
Sounds like an easy PR. Move https://github.com/sublimelsp/LSP/blob/acfd6406ba4680a0e537dc87a72aa5b410a154e7/plugin/execute_command.py#L42-L47 to a new method `on_result_async(self, response)` that the plugin will be able to override.
Would be kinda weird and hard to follow a code that executes a command in one place but handles the result in a completely different place. So I think this...