Rafał Chłodnicki
Rafał Chłodnicki
> When hovering over an annotation it seems all other annotation's text color changed: Yes. Looks like annotations don't play that well with custom styling. It works better when just...
The errors would never overlap the code. Those are always shortened to fit the available space.
Still experimenting. Brought back the code from the original @rwols' branch that showed annotation only for the diagnostic under the cursor. I think the behavior of this should be customisable....
> I feel like to solve that properly [...] have a proper region/diagnostic manager class that would control the order and "drawing" of all those things from one central place....
Specific to Rust so not much of an alternative for many, is it? :)
> Have we played with showing diagnostics as phantoms below the issue? I would consider this to be probably the worst option since it would make the content jump up...
I've decided to abandon the option for showing all diagnostics inline and only support displaying inline diagnostics for the current cursor. The other option could be added in the future...
I could work to try to add support for showing all diagnostics in the file (as a phantom below maybe).
Refactored by moving logic from `DocumentSyncListener` to `SessionView`. Mainly to be able to remove regions when SessionView is destroyed.
> Note: the popup shows up each time I navigate to the next previous result, > so we end up showing diagnostic information in both the popup and annotation, >...