Rafał Chłodnicki

Results 1204 comments of Rafał Chłodnicki

Well, without it the log would fill up with no end. Could easily reach megabytes of text. Also I guess the syntax highlighting would stop working after some point.

> The solution I came up with for that is to use this exit_handler mechanism: [sublimelsp/sublime_asyncio@`46be7ef`/globalstate.py#L140](https://github.com/sublimelsp/sublime_asyncio/blob/46be7ef44a586f5f7c79442a2a1e001f6d5b8630/globalstate.py#L140) > > However asyncio can't be used until we switch to py38. But we're...

`on_new()` just notifies about opening a new buffer and such buffer doesn't have file path associated yet. The `DidCreateFiles` registration would normally define file pattern that should be included so...

If the info is there then sounds like it could work. Though I feel at the point of `on_pre_save` the path might be set already.

Right, for those the file watcher would probably be needed.

that wouldn't cover all cases but would be an option, I guess

It's a code action actually. Changing bug description to reflect that. ``` :: --> rust-analyzer textDocument/codeAction(72): {'context': {'diagnostics': []}, 'range': {'end': {'character': 25, 'line': 22}, 'start': {'character': 25, 'line': 22}},...

There is also a small issue with the annotation collapsing if hovered shortly after the document is modified. Possibly because internally we re-create it.

> I think the error triggered the diagnostic panel, but in a flash the error disappeared and the panel didn't close automatically. I've had that happen There is no auto-close...

Would that not end up with an infinite loop if we would want to fall-back to the original `goto_definition`?