Ray Cohen
Ray Cohen
@rickpern great! I've been a little distracted but I am interested in merging this work, so let me know how I can help
@rickpern master is updated to use ember-cli 1.13.13, and tests are passing on all ember versions. Can you rebase this?
where does the deprecation warning show up? can you give me a little more info on how exactly to reproduce this?
that's a breaking change, so we'd either need a version bump or to make it opt-in. I'm inclined to go opt-in. Open to a PR that accomplishes that
I think bumping the major version to 2 and making DDAU the default behavior is probably the right path at this point. I am wondering if we can also increase...
feedback on this PR to move towards data-down actions-up is welcome https://github.com/yapplabs/ember-radio-button/pull/32 to understand the concerns raised in the PR description, I recommend playing around with the dummy app.
I'm inclined to say that like [input helpers](https://guides.emberjs.com/v2.2.0/templates/input-helpers/) the DDAU pattern doesn't fit here because it can result in the DOM being out of sync with what your application logic...
I think the wormhole is invoked **inside** the component with `_select` shown in @cdl's post. There's nothing wormhole can do about the `$` function of things containing it... right?
Problem restated without pod-style file names, and showing an action: `components/my-cool-form-template.hbs` ``` {{#ember-wormhole to="destination"}} {{/ember-wormhole}} Submit! ``` `components/my-cool-form.js` ``` Ember.Component.extend({ layout: layout, // from my-cool-form-template.hbs actions: { submit() { this.$('.focus-on-submit').focus();...
My suggestion for a better way to do this, if you want to avoid `Ember.$('#destination')`, is to make an event emitter and pass it into a component inside the wormhole:...