ember-radio-button icon indicating copy to clipboard operation
ember-radio-button copied to clipboard

Upgrade ember-cli-htmlbars to remove deprecation warning

Open jacobq opened this issue 7 years ago • 3 comments
trafficstars

The current release (1.2.1) triggers an annoying deprecation warning w/ recent versions of Ember that would be fixed by upgrading to the latest release of ember-cli-htmlbars (2.x). Please consider upgrading this.

├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected] 

The deprecation warning looks like this and is described here:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   new NPMDependencyVersionChecker (/path/to/project/node_modules/ember-getowner-polyfill/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)

jacobq avatar Jan 29 '18 15:01 jacobq

where does the deprecation warning show up? can you give me a little more info on how exactly to reproduce this?

raycohen avatar Feb 12 '18 02:02 raycohen

Good question & thanks for checking this out. The warning shows up on the console during build time (e.g. ember s). I will take a shot at posting reproduction steps later today. I thought it would show up just from installing and running on an empty project but a quick test showed otherwise.

(Update: 2/13 Sorry, still haven't had a chance to do this but have not forgotten about it.)

jacobq avatar Feb 12 '18 11:02 jacobq

I am also encountering this one.

tamzinblake avatar Feb 13 '18 19:02 tamzinblake