ember-radio-button icon indicating copy to clipboard operation
ember-radio-button copied to clipboard

Add focus-in & focus-out support

Open rickpern opened this issue 10 years ago • 6 comments
trafficstars

I wanted to be able to add focus-in and focus-out actions like you can do on the input and textarea helpers.

examples:

 {{#labeled-radio-button value=value groupValue=groupValue focus-in='onFocus' focus-out='onBlur'}}{{label}}{{/labeled-radio-button}}
 {{radio-button value=value groupValue=groupValue focus-in='onFocus' focus-out='onBlur'}}

rickpern avatar Oct 26 '15 04:10 rickpern

this looks pretty good. do you think you could add a test for it?

raycohen avatar Oct 26 '15 14:10 raycohen

@raycohen yeah, i can try to do it this week...traveling a bit, so i'll do my best. also the tests aren't failing b/c of my commits, i reverted and they still fail just FYI.

rickpern avatar Oct 26 '15 14:10 rickpern

Thanks. We run the tests against multiple versions of ember and they've been failing for a while on newer versions.

If you do get around to adding a test, I'll merge it as long as it passes against 1.11 and 1.12 (Which this PR currently does pass against)

raycohen avatar Oct 26 '15 14:10 raycohen

@raycohen i still plan on writing those tests. about to actually add some more properties to this, so i'll try to do it then.

rickpern avatar Dec 07 '15 22:12 rickpern

@rickpern great! I've been a little distracted but I am interested in merging this work, so let me know how I can help

raycohen avatar Dec 07 '15 23:12 raycohen

@rickpern master is updated to use ember-cli 1.13.13, and tests are passing on all ember versions. Can you rebase this?

raycohen avatar Jan 04 '16 16:01 raycohen