Ray Cohen
Ray Cohen
I'm dealing with this too. I hacked together https://github.com/raycohen/ember-auto-import/pull/1 as a way to allow control over when rebuilds invoke webpack. It takes some of the "auto" out of ember-auto-import but...
It can be valid to assert strictEqual on arrays and objects. For example testing that a method you called returns the exact instance of an array that was passed into...
The downside of doing this is that it means users cannot make use of the module context as the module's context is not available inside an arrow function. You're not...
If you access `this` in any arrow function where the context is tied to a module and not to a test, you can get into trouble. It doesn't even have...
Yes and even an arrow function passed as a module callback would be safe as long as it doesn't access `this`. For thoroughness we'd need to check recursively through nested...
[stable](https://github.com/embroider-build/embroider/blob/stable/packages/compat/src/compat-app-builder.ts#L399) and [main](https://github.com/embroider-build/embroider/blob/main/packages/compat/src/compat-app-builder.ts#L369) differ slightly inside `impliedAddonAssets`
I will look into testing this. Right now we're getting by with patch-package (with a slightly different diff) but we'll want to get off that eventually
One thing I noticed while debugging was if you change the contents of your lockfile while the server is running (say by running yarn install), the next rebuild's computed `cacheKey`...
in https://github.com/protobufjs/protobuf.js/pull/2068 the change to read `object.fullName` in `_handleAdd` seems to be showing as quite expensive for my app: