matt rice

Results 176 comments of matt rice

It seems like github's diff comparison doesn't pick up on the fact that macros/enum_metadata.rs is a copy of enum_fromrepr.rs with 70% similarity, but viewing in another diff tool like gitk...

So, I took a first pass at this, somehow my attempt to move out the duplicated code ended up longer than the combined duplication. It might not be very pretty,...

Wonder if we should include a `const REPR_TYPE_STR: &'static str = "u8"` for example.

Of course, I just realized that since `Default::default()` isn't const this probably be feasible...

Nice work! A further relaxation might be [type-layout](https://doc.rust-lang.org/reference/type-layout.html#reprc-structs), I believe that the restrictions can be relaxed a little more to _all non zero sized types have the same type_. there...

@RDambrosio016 Any chance you could post an example (of the output generated) for such a case where either what you're trying to achieve or how it looks using secondary labels?

This is also (somewhat) related to #200, Looking at the existing/current Label structure: ```rust pub struct Label { pub style: LabelStyle, pub file_id: FileId, pub range: Range, pub message: String,...

I ran into something similar, in the json-benchmark there is a 2mb canada.json almost all of of the contents being on a single line. It might be nice to also...

Just so I understand, you're opposed to this even when locked behind a `Config`?

I definitely think we're going to need more information, I have been running this patch alone and with lualine-lsp-progress, If I understand the backtrace: 1. your handler for jdtls calls...