matt rice

Results 180 comments of matt rice

Well, I'll do my best, from initial poking the lifetimes do seem quite intricate, because the actual closures seem like they need to be routed through the `%parse_param` extra parameter...

> > But beyond that i'm also uncertain what to do for the AStackType in this case. > > I don't think we should expose that in `parse_map`: they should,...

So far it seems to me like the output with the least amount of extra type overhead is the following: ``` #[derive(Serialize, Deserialize)] #[serde(untagged)] pub enum ASTMap

I think this one can be closed now with #592 in, it should be possible for users to implement themselves using the parse_map api.

I'll be honest I'm a little bit confused by the ci setup for this crate. While I see many testsuite failures running e.g. `cargo test`, I don't actually see the...

Probably going to take me a bit of time to go through all the changes in #340 to figure out what needs to be done to replace `test_default_generated_schema`.

> > I am surprised you are still supporting more than the most recent Ubuntu LTS. > > There are still a surprising amount of people on "old" CMake /...

Given the objections raised on my PR I don't really see this one being actionable without changes to upstream tooling. There are crates like: * https://crates.io/crates/macro-vis * https://crates.io/crates/macro-v * https://crates.io/crates/macro_pub...

I couldn't find a issue or tracking issue, but I don't think it's particulary *rustdoc*, https://internals.rust-lang.org/t/pub-on-macro-rules/19358 The macros don't show up in the `static_init` module, because they aren't *visibile* from...

Ahh, apparently this is already a feature of [macros 2.0](https://github.com/rust-lang/rfcs/blob/master/text/1584-macros.md) that works with nightly https://github.com/rust-lang/rust/issues/39412