Raphael Vallat

Hi @PascalIversen, Thanks for opening the issue. One approach that has been discussed in the past is to raise an error if the covariate(s) is identical to `x` or `y`:...

Thanks for the additional details. I think that the issue in the categorical example is that the resulting covariance matrix is rank-deficient (unless you add some random noise). This is...

Yeah, I keep hearing good things about ruff so let's change

Hi @bettina77, Despite the misleading name, the SO-spindle coupling is actually not calculated by taking co-occurring slow waves and spindles. Instead, as a true phase-amplitude coupling metric, it is calculated...

Thank you @PiethonProgram — I'll aim to review the PR later this week. In the meantime, please make sure that the CI tests and lint tests are all passing.

Yeah don't worry about the CI failures, I need to make some upgrade to the GitHub Actions workflow. Thanks!

Hey, Thanks again for the implementation and the PR. 1) I was looking at the output of the proposed implementation, and it seems that, regardless of the complexity of the...

Hi @bstucky, The documentation is not entirely correct. The amplitude is calculated on the 1-30Hz bandpass-filtered and detrended spindle: https://github.com/raphaelvallat/yasa/blob/f76f63541ae1dc10e645cdb9be9fa4b0f5eadda5/src/yasa/detection.py#L953-L956 I think we can easily add a new column with...

Hi @bettina77, > this time value is specifically used to minimize or cap filter edge artifacts and act as a buffer to avoid filter-related signal distortion during the PAC process?...

Thank you! Done in https://github.com/raphaelvallat/yasa/releases/tag/v0.6.5