Raphael Vallat

Oh shoot sorry about that! I'll be travelling for the next two days and unable to review but I can review later this week. No rush at all on the...

> Still planning to clean it up more @raphaelvallat > > I see you're adding comments, feel free but note that the PR is not finalized. Not all code is...

Ping @remrama, any updates on this? Not that we're in a rush or anything but I'd like to release a new version of YASA within the next couple of months

Hi @remrama ! Hmm, I don't think this would be appropriate in Pingouin; plus I'm trying to be very aggressive in *not* adding new features to Pingouin (call it self-preservation...

Hi @remrama ! Unfortunately I was sick for my entire week of vacation during the winter break and did not have a chance to work on the open-source libraries at...

Can you please rebase to the latest `master` (version [0.6.4](https://github.com/raphaelvallat/yasa/releases/tag/v0.6.4))? Let me know if you need help resolving conflicts.

@remrama I have no strong preference between `evaluation.EpochByEpochAgreement` or `agreement.EpochByEpochAgreement`, so if you prefer the latter please go ahead with it! > I think it's safest to open up one...

Hi Simon, `ch_names` only indicates the channel names, not the channels that should be included in the analysis. Furthermore, `ch_names` is actually discarded if the input data is a mne.Raw...

Yes we probably should — the current implementation is confusing!

Thanks @DavidALloyd, great suggestion. I apologize about the delayed response. Two things: 1) The `**kwargs` should also be added to the recursive call https://github.com/raphaelvallat/pingouin/blob/5c5f61a09ee4e49ed81716fa9485527092fcc6b0/pingouin/pairwise.py#L481 and when calculating the interaction: https://github.com/raphaelvallat/pingouin/blob/5c5f61a09ee4e49ed81716fa9485527092fcc6b0/pingouin/pairwise.py#L540...