Raphael Vallat
Raphael Vallat
Thanks for the detailed response! > But in short, I believe picking the best channel might be more accurate than the mode if that mode includes too many bad channels....
Hi @PhD-GOAT, Thanks for reporting on this issue. I have just submitted a [fix here](https://github.com/raphaelvallat/yasa/pull/162), but I might wait for a few weeks before releasing a new version of YASA...
> SleepStaging should conform to Hypnogram Good point. I'll make the change. > Do you think it's possible to add a probabilities attribute to yasa.Hypnogram? Yep, also a good idea....
It's not a bad idea at all. I'll have to think more about it. My initial preference would be to vote no, mostly because I'm being lazy and because I...
@remrama PR ready for review! I still need to update the changelog and FAQ but I think this can be done in a final PR before we release v0.7 —...
Btw I'm removing the FutureWarning in `yasa.hypno_int_to_str`. I think a lot of users are going to use it to convert their integer hypnograms to a yasa.Hypnogram instance and it's annoying...
You're welcome! Yeah I think they really did a great job, the ECG heartbeat detection has now become by go-to method. As for more HRV features, we could certainly add...
> If I have time I might write a short tutorial on how to make further use of the rpeaks that is returned by the function. That'd be great! One...
Just scrolled through the new files very quickly, this looks incredible!! Can't wait to try it and review in details in the next few days. To answer your questions: 1....
1. I'm thinking I should convert these to "Results" classes, just to match your yasa.detection module convention. Yep sounds good 2. I'm adding the more formal @property and __repr__/__str__, is...