pingouin icon indicating copy to clipboard operation
pingouin copied to clipboard

ensure compatibility with numpy 2.0

Open raphaelvallat opened this issue 1 year ago • 3 comments

See the NumPy 2.0 migration guide

raphaelvallat avatar Oct 08 '24 06:10 raphaelvallat

It's probably straightforward to run Ruff's rule once on the pingouin code to conform to Numpy 2.0. But @raphaelvallat are you cool with simultanously replacing both Black and Flake8 with Ruff? It should be configurable within pyproject.toml to match the current rules of both. They also offer a drop-in GitHub Action workflow that could replace pingouin's current Black Action. I've implemented this before on a recent project and found it a convenient one-stop solution for these things.

remrama avatar Oct 08 '24 14:10 remrama

Yeah, I keep hearing good things about ruff so let's change

raphaelvallat avatar Oct 08 '24 15:10 raphaelvallat

Adding a checklist for this Issue that combines goals of numpy 2.0 compatibility with ruff replacement.

  • [x] Replace black with ruff in pyproject.toml
  • [x] Replace flake8 with ruff in pyproject.toml
  • [x] Replace black GitHub Action with ruff GitHub action
  • [x] Run ruff's formatter (in case of minor deviations from black)
  • [x] Run ruff's linter (in case of minor deviations from flake8)
  • [x] Run ruff's numpy 2.0 compatibility enforcer
  • [x] Replace black and flake8 with ruff in Contributing sections in docs and README.

remrama avatar Oct 09 '24 15:10 remrama

@raphaelvallat this got addressed when #446 was merged, so you can close it as completed 👍 ✅

remrama avatar Dec 08 '24 20:12 remrama