Ran Shidlansik

Results 195 comments of Ran Shidlansik

> Hi @ranshid , this is just the review of the entry.c code that you can check while I continue to review the rest of the code. Thank you @rjd15372...

> ## [Codecov](https://app.codecov.io/gh/valkey-io/valkey/pull/2089?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valkey-io) Report > Attention: Patch coverage is `90.21739%` with `90 lines` in your changes missing coverage. Please review. > > > Project coverage is 71.59%. Comparing base [(`1e05724`)](https://app.codecov.io/gh/valkey-io/valkey/commit/1e05724f592025535d4e53a700d65486e715a2a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valkey-io)...

there is a new memory leak which I have never seen before: https://github.com/valkey-io/valkey/actions/runs/16019103541/job/45191596412?pr=2089 Maybe related to the last refactoring. I will try and reproduce

> there is a new memory leak which I have never seen before: https://github.com/valkey-io/valkey/actions/runs/16019103541/job/45191596412?pr=2089 > > Maybe related to the last refactoring. I will try and reproduce Fixed. also added...

reviewers: note my last [commit](https://github.com/valkey-io/valkey/pull/2089/commits/15f7ab82f963c38b4d0a553bb18800e6112ea18b) I verified it using the force defrag (which failed without this fix)

reviewers, sorry. has to force push since I accidentally pushed changes from another branch (we will have to merge all the 3 PRs soon as working on3 branches is a...

NOTE - we decided to remove the NX/XX options for `HSETEX` in order to be better aligned with existing clients. we will consider adding them later

> so module auth can add reply in its callback, or not add reply and just return an err robj in its callback? And we have to figure a way...

> So, I think OCSP stapling is the wrong thing to do for databases as a whole (The clients are the right place to be doing this validation). I have...

We should merge the requests in a single place, probably: #640 @tugtugtug can you +1 there?