Ranieri Althoff
Ranieri Althoff
Probably related to VS's inability to handle folders. (Please please use CMake with VS)
Future work hopefully involves ditching the vc17 thing and using CMake :laughing:
Just keep a running counter of players online that increases with a creaturescript of type `login` and decreases with a `logout`
Won't this indefinitely append nodes to the `nodeStore` vector? Why not store unique pointers in `nodes`? It seems that every `emplace_back` is done on both
@NRH-AA is this still relevant after #4934 ?
@Zbizu for sure, I just didn't think of an easier way to convert en masse with that format. I'll have a look into that
> wouldn't it be possible to move to local namespace? No, they are used elsewhere. Could be moved to a namespace but I would do it separately
Logging is a great addition, but do we need to wrap it? We could use spdlog directly, the API seems quite clean and easy
> Imo it should be something like `...signature`. This is good. I'm thinking about not even using the dots, and using the uint64_t account ID and (u)int64_t timestamp, fixing the...
There is no need to store the password. If you're signing, you can trust the account ID alone. Also, don't truncate the hash, you're slashing security by doing to. With...