Ranieri Althoff

Results 385 comments of Ranieri Althoff

Nice, so this is one of the few use-after-move situations that are defined 😆 good to go

If seek is not used, tell is likely not used too

This is a very hot code path and I'd rather not add the check. If not even the engine needs to arbitrarily navigate a network message, I don't think the...

I see that the README lists 2024-10-22 as the maintenance start date of v20, but it is still marked as LTS. So what is the current state of it? It's......

Wtf what compiler was complaining about this

> So, what is the purpose of the bindOnlyGlobalAddress function? It allows the server to respond on all IP addresses on the machine, not just the loopback address (127.0.0.1). In...

These values are described in `.env.example` that is shipped and shouldn't be ignored. How about you add these entries back but instead of defaulting to a possibly invalid value, load...

> IDK how `/reload` can be made memory safe (no crashes) and not leaking. It can't unless we use smart pointers for _everything_ and even then, it may lead to...

It's just weird to add these extra function calls, like `initState` after `reinitState`. `reinitState` should probably be modified to do more of what `initState` does instead, or just dropped and...

Does including `otpch.h` in these files help?