forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

Fix Visual Studio precompiled header error

Open ramon-bernardo opened this issue 1 year ago • 4 comments

Pull Request Prelude

Changes Proposed

  • This resolves the error C1010: unexpected end of file while looking for precompiled header in Visual Studio. The issue occurred because the precompiled header was not included in the source file. As a temporary fix, if anyone has a better suggestion for resolving this.

image

ramon-bernardo avatar Sep 29 '24 20:09 ramon-bernardo

Does including otpch.h in these files help?

ranisalt avatar Sep 29 '24 21:09 ranisalt

Does including otpch.h in these files help?

The file is already included; it seems that Visual Studio gets confused due to its own config. image

ramon-bernardo avatar Sep 29 '24 22:09 ramon-bernardo

Probably related to VS's inability to handle folders.

(Please please use CMake with VS)

ranisalt avatar Sep 29 '24 23:09 ranisalt

https://github.com/otland/forgottenserver/pull/4875 similar fix

ArturKnopik avatar Dec 20 '24 12:12 ArturKnopik