Ranieri Althoff

> Token PHP code you posted with just accountId and timestamp already generates 88 bytes for account `123` It's actually 32 bytes for the hash + 8 bytes for account...

I see no value in adding a checksum at the end. However, sending the account id + timestamp and signing those with HMAC should be safe enough to assume it...

Namespaces are the right way to group functions, classes with static functions are a legacy hack. Ramon just rage quit those PRs 😆 feel free to rework on them

Currently it only ignores case, e.g. speling *eXuRa* will show *exura*, it is probably easy to do the second part (ignoring old-style comments) but for the first one it may...

@kygov correct, I see a few calls to `g_actions->loadFromXml()` are still present which will print the error message. With the new code, reloading actions is done through reloading scripts instead,...

If you [read my previous issue](https://github.com/napi-rs/node-rs/issues/841) you will see that @node-rs/argon2 defaults are much lower (it's even wrong compared to the README). You must compare the libraries using the same...

@paulmillr this is a pretty common misconception given the README has been misleading users since the very beginning. This is not the first post I see claiming @node-rs/argon2 is faster...

I'm afraid that's not enough. Your post still claims incorrect numbers and a link at the top won't cut it, I think you should re-run the tests and update the...

We're (me and @ramon-bernardo) are halfway there in https://github.com/ranisalt/forgottenserver/pull/9 but there are a few issues still. I'm going to open a PR here when it's done

The smart pointer PR is just getting split so it's easier to track issues and review