Dhruv Rajpara
Dhruv Rajpara
> Hi @rajparad! Apologies for the review delay on this one. This all looks good from a code perspective - nice work! I will ask our designers to review further...
Hello @tonisevener, There was a feedback from design to show alert. there are 2 ways. Let me know what is your preference from code perspective. I can update accordingly :)....
Hello @lmarceau, I guess still there is no PR for this. I am not sure is there any PR option for WIKI? But in my forked repo I have updated...
Hello @lmarceau , I checked in iPhone 14 in iOS 17.2. but it's not showing me share button. I am new to open source contribution. let me know if I...
Hello @lmarceau , Thanks for the info. After debugging I found that in `ShareButton` class, `override open var isHighlighted: Bool { didSet { self.tintColor = isHighlighted ? selectedTintColor : unselectedTintColor...
@lmarceau , sure I can. but I am not sure about ticket number. as I don't have access for JIRA
> The ticket number can be found if you hover your mouse on the Jira task link as shown in this screenshot:  >...
For this issue, I think it's not only in iPad. I also checked for Mobile, after comparing it App store it seems like there is more padding. I am attaching...
Hello @tonisevener, Thanks for the feedback. I have updated the code to show warning. For now it's only show one time for a user. Here is the link: https://github.com/wikimedia/wikipedia-ios/pull/4790/files Only...
> @rajparad Thanks! A few more changes needed. Also our project changed a bit with some recent merges (a git submodule was deleted, and the name of `PageEditorViewController` changed to...