firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Wiki pages: Minor grammar errors in 'A Brief Overview of Accessibility'

Open skiing-gecko opened this issue 1 year ago • 4 comments

When I was looking over the accessibility page of the Wiki, I think I found some mistakes in the writing:

In the accessibilityHint section there are two 'the's:

Hints can be turned off by the the users, but aren't less useful to give more context as to what an element on the screen does.

In the Grouping Elements section, there is a space between 'm' and 'ore' in the word 'more':

As a user, it's much m ore preferable to have the whole cell selectable with Voice Over...

In the accessibilityIdentifier section, there seems to be an 'or' in place of an 'of':

An easy way or organizing reusable identifiers can be found...

I also thought that the sentence

In that case, the labels in that cells needs their accessibilityElement turned off, and the parent cell needs it's accessibilityElement turned on, and it's accessibility label can be set as the combined text of the title and the description.

Might be better written as:

In that case, the labels in those cells need their accessibilityElement turned off, and the parent cell needs its accessibilityElement turned on, and its accessibility label can be set as the combined text of the title and the description.

I imagine this is very low on the list of things to do, but I thought it might be helpful to point it out :)

┆Issue is synchronized with this Jira Task

skiing-gecko avatar Apr 24 '23 22:04 skiing-gecko

@skiing-gecko do you want to open a PR to improve the wiki page?

lmarceau avatar Apr 25 '23 14:04 lmarceau

Is it OK if i take this on? I can go and update it if @skiing-gecko hasn't had a chance to get around to it :)

dfperry5 avatar Apr 30 '23 15:04 dfperry5

@dfperry5 there's no PR open for it, so I would say go for it 🙏

lmarceau avatar May 01 '23 14:05 lmarceau

Hello @lmarceau, I guess still there is no PR for this. I am not sure is there any PR option for WIKI? But in my forked repo I have updated the page with new grammar.

Here is the link of my wiki: https://github.com/rajparad/firefox-ios.wiki.git and page with changes: https://github.com/rajparad/firefox-ios/wiki/A-Brief-Overview-of-Accessibility

Let me know if something needs to be changed.

rajparad avatar Feb 16 '24 22:02 rajparad

I just took a look and there doesn't seem to be any options to have PR for wiki pages on main. I made changes on the page as you did them @rajparad :) Let me know if you see anything else, otherwise I'll close this issue for now. Thank you!

lmarceau avatar Feb 20 '24 16:02 lmarceau